Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ext-redis v6.0 #79

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

boesing
Copy link
Member

@boesing boesing commented Sep 13, 2023

Q A
BC Break no
New Feature yes

Description

This adds support for redis extension v6.0

Signed-off-by: Maximilian Bösing <[email protected]>
@boesing boesing added this to the 2.6.0 milestone Sep 13, 2023
@boesing boesing linked an issue Sep 13, 2023 that may be closed by this pull request
@boesing
Copy link
Member Author

boesing commented Sep 13, 2023

Seems like somehow constants were moved with phpredis/phpredis@2a6dee5

Created an issue phpredis/phpredis#2384 as that was not mentioned in the changelog and that also does not like as it is intended.

@boesing boesing force-pushed the feature/redis-extension-v6 branch 2 times, most recently from 8488fbe to 5444b27 Compare September 13, 2023 21:15
With v6.0.0, options were dropped from `RedisCluster` and therefore we have to switch to `Redis` constants

Signed-off-by: Maximilian Bösing <[email protected]>
The latest version in v4 was 4.3.0 which is only installable with >5.3.0 <= 7.9.99

Signed-off-by: Maximilian Bösing <[email protected]>
This allows the CI container to pick the already installed version.

Signed-off-by: Maximilian Bösing <[email protected]>
@boesing boesing merged commit 8673eb4 into laminas:2.6.x Sep 13, 2023
18 checks passed
@boesing boesing deleted the feature/redis-extension-v6 branch September 13, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ext-redis ^6.0
1 participant